Well I will only speak of the pump I use.
Pro's..
It can generate over 150 PSI on a small nozzle, actually there is a post on this board whereby someone pin'd a 250 PSI pressure guage with one bypass'd. And another blew apart a solenoid.
Has been rated by the MFG at 1500 hrs continuous,
I have had zero pumps fail in the year i've been selling these systems,
In relative terms, its inexpensive.
My supplier sells 3500-4000 of these pumps a year, over the last 6 years he's had less than a handful back.
Mine has been sitting in straight 100% methanol since April '03
Cons.. its big, ugly, response due to mass is slower than an EFI pump, is not smooth in its fluid delivery due to its diaphram design, and not compatible with oils(like gasoline).
Only reported flaw in the pump, on the net I have ever seen has been a leaky pressure switch assembly. And someone who reported theyre mounting bracket broke.
On the not smooth delivery issue, it has not shown to be an issue on any system i've put together. Or on anyones application.
I cant say how pumps have been shipped, treated, mounted, installed, etc.. Only from what i've been able to research. None of the reported problems have been from my customers. Just from those using the same style pump.
Lastly there have been no reports of the motor ever failing.
Anything I miss?